Fix(domain-trie): crash when insert

This commit is contained in:
gVisor bot 2019-09-14 21:42:40 +08:00
parent 8acadd2932
commit 3846c2fbe3
2 changed files with 5 additions and 1 deletions

View File

@ -22,7 +22,7 @@ type Trie struct {
} }
func isValidDomain(domain string) bool { func isValidDomain(domain string) bool {
return domain[0] != '.' && domain[len(domain)-1] != '.' return domain != "" && domain[0] != '.' && domain[len(domain)-1] != '.'
} }
// Insert adds a node to the trie. // Insert adds a node to the trie.

View File

@ -26,6 +26,10 @@ func TestTrie_Basic(t *testing.T) {
if !node.Data.(net.IP).Equal(localIP) { if !node.Data.(net.IP).Equal(localIP) {
t.Error("should equal 127.0.0.1") t.Error("should equal 127.0.0.1")
} }
if tree.Insert("", localIP) == nil {
t.Error("should return error")
}
} }
func TestTrie_Wildcard(t *testing.T) { func TestTrie_Wildcard(t *testing.T) {