From 306843fe6af14dcfe499eecab5ff86a4227eca4e Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Wed, 6 Nov 2024 16:42:04 +0800
Subject: [PATCH] chore: plugin info

---
 .../plugins/plugin-detail-panel/detail-header.tsx    |  5 +++--
 .../components/plugins/plugin-page/plugin-info.tsx   | 12 ++++++------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/web/app/components/plugins/plugin-detail-panel/detail-header.tsx b/web/app/components/plugins/plugin-detail-panel/detail-header.tsx
index 37831368e2..2f8ec889f4 100644
--- a/web/app/components/plugins/plugin-detail-panel/detail-header.tsx
+++ b/web/app/components/plugins/plugin-detail-panel/detail-header.tsx
@@ -52,13 +52,14 @@ const DetailHeader = ({
     meta,
   } = detail
   const { author, name, label, description, icon, verified } = detail.declaration
+  const isFromGitHub = source === PluginSource.github
   // Only plugin installed from GitHub need to check if it's the new version
   const hasNewVersion = useMemo(() => {
     return source === PluginSource.github && latest_version !== version
   }, [source, latest_version, version])
 
   // #plugin TODO# update plugin
-  const handleUpdate = () => {}
+  const handleUpdate = () => { }
 
   const [isShowPluginInfo, {
     setTrue: showPluginInfo,
@@ -151,7 +152,7 @@ const DetailHeader = ({
       <Description className='mt-3' text={description[locale]} descriptionLineRows={2}></Description>
       {isShowPluginInfo && (
         <PluginInfo
-          repository={meta?.repo}
+          repository={isFromGitHub ? meta?.repo : ''}
           release={version}
           packageName={meta?.package}
           onHide={hidePluginInfo}
diff --git a/web/app/components/plugins/plugin-page/plugin-info.tsx b/web/app/components/plugins/plugin-page/plugin-info.tsx
index ebec25f216..6e30834c49 100644
--- a/web/app/components/plugins/plugin-page/plugin-info.tsx
+++ b/web/app/components/plugins/plugin-page/plugin-info.tsx
@@ -7,9 +7,9 @@ import Modal from '../../base/modal'
 
 const i18nPrefix = 'plugin.pluginInfoModal'
 type Props = {
-  repository: string
-  release: string
-  packageName: string
+  repository?: string
+  release?: string
+  packageName?: string
   onHide: () => void
 }
 
@@ -30,9 +30,9 @@ const PlugInfo: FC<Props> = ({
       closable
     >
       <div className='mt-5 space-y-3'>
-        <KeyValueItem label={t(`${i18nPrefix}.repository`)} labelWidthClassName={labelWidthClassName} value={repository} />
-        <KeyValueItem label={t(`${i18nPrefix}.release`)} labelWidthClassName={labelWidthClassName} value={release} />
-        <KeyValueItem label={t(`${i18nPrefix}.packageName`)} labelWidthClassName={labelWidthClassName} value={packageName} />
+        {repository && <KeyValueItem label={t(`${i18nPrefix}.repository`)} labelWidthClassName={labelWidthClassName} value={repository} />}
+        {release && <KeyValueItem label={t(`${i18nPrefix}.release`)} labelWidthClassName={labelWidthClassName} value={release} />}
+        {packageName && <KeyValueItem label={t(`${i18nPrefix}.packageName`)} labelWidthClassName={labelWidthClassName} value={packageName} />}
       </div>
     </Modal>
   )